Skip to content

Disable disk cache in hf_xet by default through cargo system. #559

Merged
hoytak merged 2 commits intomainfrom
hoytak/251106-conditional-cache-config
Nov 10, 2025
Merged

Disable disk cache in hf_xet by default through cargo system. #559
hoytak merged 2 commits intomainfrom
hoytak/251106-conditional-cache-config

Conversation

@hoytak
Copy link
Collaborator

@hoytak hoytak commented Nov 6, 2025

This PR disables the disk cache by default in hf_xet using cargo features instead of in-code logic.

Reverts #535

@hoytak hoytak requested review from rajatarya and seanses November 6, 2025 20:32
Copy link
Contributor

@assafvayner assafvayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rajatarya
Copy link
Collaborator

Oh, now I get this - love it! I think the only thing left is to back out the Some(0) parts of the previous commit. Do you want to handle that or do you want me to add to this PR/do a separate PR?

Copy link
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

@hoytak
Copy link
Collaborator Author

hoytak commented Nov 6, 2025

Love this!

I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

This PR should fully revert that PR. Did I miss something? I don't see any Some(0) leftover here.

Copy link
Collaborator

@rajatarya rajatarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love it! :shipit:

@rajatarya
Copy link
Collaborator

Love this!
I think the other part is to back out the Some(0) changes from my previous PR, and then do some quick sanity testing to verify things remain working as expected.

This PR should fully revert that PR. Did I miss something? I don't see any Some(0) leftover here.

My mistake, I clicked on the commit in the Slack message and only reviewed those changes - didn't see the full PR right away. Sorry about that.

@hoytak hoytak merged commit 3904178 into main Nov 10, 2025
10 of 11 checks passed
@hoytak hoytak deleted the hoytak/251106-conditional-cache-config branch November 10, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants