Fix breaking build changes due to git safety checks.#530
Merged
Conversation
seanses
approved these changes
Oct 20, 2025
seanses
reviewed
Oct 20, 2025
Collaborator
There was a problem hiding this comment.
Turns out it's the user in the docker container is different from the owner of the repo. So the fix is to run git config --global --add safe.directory "*" in the docker container. See successful build: https://github.com/huggingface/xet-core/actions/runs/18661456190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build break due to git safety checks.
The recent logging PR added the automatic logging of the git repository commit hash that was used to build the wheel. However, this requires querying for this hash at build time, which requires running git. It turns out that in the CI, the user checking out the repository and the user building the wheel are different, which makes git upset. This PR adds code to tell git everything will be ok.