Skip to content

Fix python 314 compat#520

Merged
assafvayner merged 3 commits intohuggingface:mainfrom
Qubitium:fix-python-314-compat
Oct 2, 2025
Merged

Fix python 314 compat#520
assafvayner merged 3 commits intohuggingface:mainfrom
Qubitium:fix-python-314-compat

Conversation

@Qubitium
Copy link
Contributor

@Qubitium Qubitium commented Oct 2, 2025 •
edited
Loading

Fix python 3.14 build compat

  1. pyo3 depend updated to 0.26: this is required or else it can't be compiled for python 3.14
  2. version update to 1.1.11-dev0
# removed
Fix compat with Rustc 1.86.0
3. change rust conditions that was throwing `unstable` `errors` in `rustc 1.86.0 (05f9846f8 2025-03-31)` (fairly new version, not the latest) _

@hoytak @seanses @assafvayner

seanses
seanses requested changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@seanses seanses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade your Rust toolchain to 1.89.0+. We really like the let chains feature.

@Qubitium Qubitium force-pushed the fix-python-314-compat branch from 6bd0b76 to b50554a Compare October 2, 2025 17:50
@Qubitium
Copy link
Contributor Author

Qubitium commented Oct 2, 2025

Please upgrade your Rust toolchain to 1.89.0+. We really like the let chains feature.

Done.

@Qubitium Qubitium requested a review from seanses October 2, 2025 17:54
assafvayner
assafvayner requested changes Oct 2, 2025
View reviewed changes
@Qubitium Qubitium requested a review from assafvayner October 2, 2025 18:22
@Qubitium Qubitium force-pushed the fix-python-314-compat branch from 99cf8f5 to 29fa3f2 Compare October 2, 2025 18:38
@seanses
Copy link
Collaborator

seanses commented Oct 2, 2025 •
edited
Loading

Thanks! Can you also fix the lint errors introduced by the upgrade (see the below failed workflow)?

@Qubitium
Copy link
Contributor Author

Qubitium commented Oct 2, 2025 •
edited
Loading

@seanses Now using latest pyo3 non-deprecated semantics:

py::allow_threads -> py::detach
py::with_gil -> py::attach

7984038

Please re-trigger workflow.

seanses
seanses approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@seanses seanses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@rajatarya
Copy link
Collaborator

rajatarya commented Oct 2, 2025

This is awesome, thanks @Qubitium for the contribution!

@assafvayner assafvayner merged commit 975e867 into huggingface:main Oct 2, 2025
6 checks passed
@Qubitium Qubitium deleted the fix-python-314-compat branch October 3, 2025 16:13
@seanses seanses mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanses seanses seanses approved these changes

@assafvayner assafvayner assafvayner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Qubitium @seanses @rajatarya @assafvayner