git-xet Windows installer and code signing#519
Merged
Conversation
assafvayner
approved these changes
Oct 2, 2025
rajatarya
approved these changes
Oct 2, 2025
Collaborator
rajatarya
left a comment
There was a problem hiding this comment.
I have a couple minor things - nothing that should block this from getting merged.
jgodlew
approved these changes
Oct 2, 2025
rtrompier
reviewed
Oct 6, 2025
| with: | ||
| azure-tenant-id: ${{ inputs.azure_tenant_id }} | ||
| azure-client-id: ${{ inputs.azure_client_id }} | ||
| azure-client-secret: ${{ inputs.azure_client_secret }} |
There was a problem hiding this comment.
Not urgent, but could we use the Github Oauth instead of client ID / Secret?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
A test commit created a pre-release at https://github.com/huggingface/xet-core/releases/tag/git-xet-v0.1.0 with the signed Windows executables.