Added lazy evaluation functionality to error printer.#510
Merged
Conversation
assafvayner
approved these changes
Sep 24, 2025
Contributor
assafvayner
left a comment
There was a problem hiding this comment.
🚢 this is useful generally, glad that you added it.
Contributor
|
FYI @jgodlew too |
seanses
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the full message given to a function in error_printer must be always created. This causes extra work when there are no errors if the message should contain additional data.
This PR introduces
_fnversions of the existing functions that call a given function on demand to obtain the message. Thus.warn_error_fn(|| format!("Error processing {context}"))would only allocate and create the error string when an error needs to be logged.