Skip to content

hashing and chunking example tools#496

Merged
assafvayner merged 14 commits intomainfrom
assaf/hashing-and-chunking-examples
Sep 26, 2025
Merged

hashing and chunking example tools#496
assafvayner merged 14 commits intomainfrom
assaf/hashing-and-chunking-examples

Conversation

@assafvayner
Copy link
Contributor

@assafvayner assafvayner commented Sep 17, 2025

Adds some basic examples tools (compiled with cargo build --examples on data crate) to compute hashes and chunk boundaries.

@assafvayner assafvayner marked this pull request as ready for review September 22, 2025 23:32
Copy link
Collaborator

@seanses seanses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor suggestions.


// set up writer to output chunks information
let mut output: Box<dyn Write> = if let Some(save) = args.output {
Box::new(BufWriter::new(File::create(save).unwrap()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit -- might be good to use expect instead of unwrap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "dumb" example tool, I consider unwraps here fine

@assafvayner assafvayner merged commit c55fabb into main Sep 26, 2025
6 checks passed
@assafvayner assafvayner deleted the assaf/hashing-and-chunking-examples branch September 26, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants