Skip to content

upgrade rust edition to 2024; upgrade rustc to 1.89#494

Merged
seanses merged 4 commits intomainfrom
di/upgrade-to-rust-edition-2024-and-rustc-1.89
Sep 17, 2025
Merged

upgrade rust edition to 2024; upgrade rustc to 1.89#494
seanses merged 4 commits intomainfrom
di/upgrade-to-rust-edition-2024-and-rustc-1.89

Conversation

@seanses
Copy link
Collaborator

@seanses seanses commented Sep 16, 2025

  • Upgrade Rust edition and rustc version to bring in some nice features, e.g. let chains instead of nested if block.
  • Fix clippy and format due to the upgrade.
  • Fix a bug identified by the new rustc:
    TokioRuntimeBuilder::new_multi_thread().worker_threads(get_num_tokio_worker_threads())
#[cfg(not(target_family = "wasm"))]
{
    // A new multithreaded runtime with a capped number of threads
    TokioRuntimeBuilder::new_multi_thread().worker_threads(get_num_tokio_worker_threads())
}

here the end curly bracket drops the temporary builder while a &mut Self to the dropped value is returned. (this may be due to a difference between compilers regarding how they treat the scope of "{...}" of #[cfg(...))] {...}?)

@seanses seanses force-pushed the di/upgrade-to-rust-edition-2024-and-rustc-1.89 branch from 1c70b8f to f1d63c2 Compare September 16, 2025 22:14
@seanses seanses marked this pull request as ready for review September 16, 2025 22:21
Copy link
Collaborator

@sirahd sirahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seanses seanses merged commit fa030ed into main Sep 17, 2025
6 checks passed
@seanses seanses deleted the di/upgrade-to-rust-edition-2024-and-rustc-1.89 branch September 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants