Merged
Conversation
Collaborator
rajatarya
commented
Sep 11, 2025
- Adds diagnostic scripts to root of repo and references them in README.
- Also reorganizes README to make diagnostics & debugging more visible.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds diagnostic scripts for debugging hangs and performance issues with hf-xet, along with reorganizing the README to make diagnostics and debugging information more prominent and accessible.
- Adds Linux and Windows diagnostic scripts that automatically collect system info, download debug symbols, and capture periodic stack traces or dumps
- Reorganizes README structure to move debugging content earlier and make it more visible to users encountering issues
- Updates contribution section placement for better README flow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| hf-xet-diag-linux.sh | Linux diagnostic script using gdb/gcore for stack traces and core dumps, with optional ptrace helper |
| hf-xet-diag-windows.sh | Windows diagnostic script using ProcDump for periodic mini dumps, designed for Git-Bash |
| README.md | Reorganized to promote diagnostics section and added comprehensive documentation for the diagnostic scripts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.