Thin wasm: do not automatically set is_dedup to true for first chunk#481
Merged
coyotte508 merged 1 commit intomainfrom Sep 6, 2025
Merged
Thin wasm: do not automatically set is_dedup to true for first chunk#481coyotte508 merged 1 commit intomainfrom
coyotte508 merged 1 commit intomainfrom
Conversation
Contributor
Best to ensure this is still done, the best chance to dedupe large parts of files is on first chunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to huggingface/huggingface.js#1718
We'll want to edit parts of file while loading old data's dedup info
In those case we don't always want to load dedup info for the first chunk (since it may not be at the beginning of the file)
So the is_dedup = true for first chunk is handled client side