Adding retry for unhandled io errors when sending requests#468
Merged
Conversation
Collaborator
|
I just ran a test on this PR, it seems that the "os error 55" is not caught or retried: https://github.com/huggingface/xet-scenario-tests/actions/runs/17216048201/job/48839818576#step:13:196 |
assafvayner
reviewed
Aug 26, 2025
assafvayner
approved these changes
Aug 26, 2025
Contributor
Author
|
@seanses the errors are now being caught and retried properly: ci-run. Downloading the logs from that run shows that there are However, in testing, I did notice that sometimes, retrying 5 times was insufficient. Lowering the number of concurrent range gets ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to retry errors when we receive I/O errors when sending requests. For example, on macOS, when we see:
when downloading from S3, we should wait and retry once the system has more network resources.