Skip to content

[WIP] [Liger] liger JSD support#2573

Closed
Mecoli1219 wants to merge 1 commit into
huggingface:mainfrom
Mecoli1219:liger-jsd-gkd
Closed

[WIP] [Liger] liger JSD support#2573
Mecoli1219 wants to merge 1 commit into
huggingface:mainfrom
Mecoli1219:liger-jsd-gkd

Conversation

@Mecoli1219

Copy link
Copy Markdown

What does this PR do?

Add support for Liger-kernel chunked losses for the JSD

Needs: linkedin/Liger-Kernel#425

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
@kashif

kashif commented Aug 24, 2025

Copy link
Copy Markdown
Collaborator

closing in favour of #3946

@kashif kashif closed this Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants