-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Always allow ref_model=None #2047
Copy link
Copy link
Closed
Labels
✨ enhancementNew feature or requestNew feature or request🏋 DPORelated to DPORelated to DPO🙋 help from community wantedOpen invitation for community members to contributeOpen invitation for community members to contribute🧒 good second issueGood for contributors with basic project familiarityGood for contributors with basic project familiarity
Metadata
Metadata
Assignees
Labels
✨ enhancementNew feature or requestNew feature or request🏋 DPORelated to DPORelated to DPO🙋 help from community wantedOpen invitation for community members to contributeOpen invitation for community members to contribute🧒 good second issueGood for contributors with basic project familiarityGood for contributors with basic project familiarity
Type
Fields
Give feedbackNo fields configured for issues without a type.
Feature request
For optimisation with reference model, in most cases the reference model is the same as the trained model. We should allow the user to specify the ref model only when they don't want to use the trained model.
Currently this is possible, but only when using PEFT, which is very counter-intuitive. And even using this situation, if you want to provide a ref model that is different from the trained model, you have to define force_use_model. Even more counter-intuitive.
Currently
Proposed
Motivation
Make the lib use more intuitive.
Your contribution
For sure ;)