[Flax] Bugfixes in run_mlm_flax.py#9127
Closed
TevenLeScao wants to merge 4 commits intohuggingface:masterfrom
TevenLeScao:run_mlm_flax_bugfixes
Closed
[Flax] Bugfixes in run_mlm_flax.py#9127TevenLeScao wants to merge 4 commits intohuggingface:masterfrom TevenLeScao:run_mlm_flax_bugfixes
run_mlm_flax.py#9127TevenLeScao wants to merge 4 commits intohuggingface:masterfrom
TevenLeScao:run_mlm_flax_bugfixes
Conversation
sgugger
reviewed
Dec 15, 2020
| ).create(model.params) | ||
|
|
||
| # Create learning rate scheduler | ||
| # warmup_steps = 0 causes the Flax optimizer to return NaNs; warmup_steps = 1 is functionally equivalent. |
Collaborator
There was a problem hiding this comment.
We could a do a logger.warning(...) if training_args.warmup_steps happens to be 0.
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a few bugs I have observed when using
run_mlm_flax.py:jnp.splitis a lot slower thannp.spliton the first iteration, outright hanging in my tests on simplewiki (~20MB). As this operation doesn't need to be traced. we can usenp.splitinstead.datasets, the text column was also passed to the model as input, causing a bug. The PR removes the text column indataset.mapto avoid this.warmup_steps = 0(as is default) causes the Flax optimizer to output NaNs. We use 1 as a minimum value for the same warmup-less behaviour.