Add AzureML in integrations via dedicated callback #8062
Add AzureML in integrations via dedicated callback #8062LysandreJik merged 14 commits intohuggingface:masterfrom davidefiocco:azuremllogging
Conversation
sgugger
left a comment
There was a problem hiding this comment.
Looks great!
There is just a conflict to solve (probably with MLFlow merged this morning) and the CI tools to make happy (your import might need some comment to be ignored by black/isort).
|
Code changes pass tests @sgugger ! Thanks @alvarobartt for having a look at those also. I guess I need to take care of docs/source/main_classes/callback.rst as well to complete the checklist though? |
|
Yes, if you could add a line to the rst file, that would be great! |
|
You might need to rebase to have the latest script for doc formatting, which should do everything to make the CI happy with just |
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, thanks!
As you mention hacktoberfest, we had not thought of adding the label but we just did. I hope this PR will be counted towards your goal!
What does this PR do?
I propose this PR to allow transformers to call AzureML logging using https://docs.microsoft.com/en-us/python/api/azureml-core/azureml.core.run(class)?view=azure-ml-py
The intended behaviour is to enable
transformersusers to track metrics in the AzureML UI in this fashionContributors to https://github.com/microsoft/AzureML-BERT and folks @microsoft may well come up with a better implementation though!
I am glad to improve the following if reviewers like the idea, and update docs and tests if needed.
@reviewers feel free to add any suggestions as my contributions to transformers have been very limited so far :)
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@julien-c is aware of this and @sgugger participated in the thread on forums above and implemented callbacks with #7596