Skip to content

[GLM-OCR] GLM-OCR Support#43391

Merged
ArthurZucker merged 30 commits intohuggingface:mainfrom
zRzRzRzRzRzRzR:glm
Jan 27, 2026
Merged

[GLM-OCR] GLM-OCR Support#43391
ArthurZucker merged 30 commits intohuggingface:mainfrom
zRzRzRzRzRzRzR:glm

Conversation

@zRzRzRzRzRzRzR
Copy link
Copy Markdown
Contributor

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR commented Jan 21, 2026

Need reivew for @zucchini-nlp

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR changed the title GLM-OCR support [GLM-OCR] GLM-OSR Test Support Jan 21, 2026
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as draft January 21, 2026 13:42
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR changed the title [GLM-OCR] GLM-OSR Test Support [GLM-OCR] GLM-OCR Test Support Jan 21, 2026
zucchini-nlp
zucchini-nlp reviewed Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of modular! Only a few comments and I think the PR will be ready to merge! Also, since the model isn't yet released, let's skip slow integration tests with a "reason" so that CI doesn't complain

Comment thread src/transformers/models/auto/configuration_auto.py
Comment on lines +187 to +189
("glm_ocr", "GlmOcrConfig"),
("glm_ocr_text", "GlmOcrTextConfig"),
("glm_ocr_vision", "GlmOcrVisionConfig"),
Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to myself: this is getting too reprtitive with more MM models added. Will try to come up with a cleaner way!

Comment thread tests/models/glm_ocr/test_modeling_glm_ocr.py Outdated
Comment thread tests/models/glm_ocr/test_modeling_glm_ocr.py Outdated
Comment thread tests/models/glm_ocr/test_modeling_glm_ocr.py Outdated
Comment thread src/transformers/models/glm_ocr/modular_glm_ocr.py Outdated
Comment thread src/transformers/models/glm_ocr/modular_glm_ocr.py Outdated
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR mentioned this pull request Jan 22, 2026
Merged
zucchini-nlp
zucchini-nlp approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for un-skipping those tests! I will let you fix one last test that is failing (compile_fullgraph) and ask for Arthur's review. Then we can merge

When done fixing, can you also mark PR as ready for review?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Jan 23, 2026

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 24, 2026

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43391&sha=48594f

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as ready for review January 25, 2026 13:16
@zRzRzRzRzRzRzR
Copy link
Copy Markdown
Contributor Author

zRzRzRzRzRzRzR commented Jan 25, 2026 •
edited
Loading

This PR also removes all restrictions on image sizes smaller than 28 in GLM-V (support in all GLM-V models)

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR changed the title [GLM-OCR] GLM-OCR Test Support [GLM-OCR] GLM-OCR Support Jan 25, 2026
@zucchini-nlp
Copy link
Copy Markdown
Member

zucchini-nlp commented Jan 26, 2026

Oke, will fix tests and then can merge

ArthurZucker
ArthurZucker approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks great modular, lgtm

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) January 27, 2026 08:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, glm46v, glm4v, glm4v_moe, glm_ocr

@ArthurZucker ArthurZucker disabled auto-merge January 27, 2026 12:22
@ArthurZucker ArthurZucker merged commit 4854dbf into huggingface:main Jan 27, 2026
21 of 25 checks passed
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR deleted the glm branch January 27, 2026 13:28
@NielsRogge NielsRogge mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@zucchini-nlp zucchini-nlp zucchini-nlp approved these changes

Assignees

No one assigned

Labels

New model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zRzRzRzRzRzRzR @HuggingFaceDocBuilderDev @zucchini-nlp @ArthurZucker @molbap