Closed
Conversation
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43201&sha=a9b5dc |
Contributor
|
Similar issue as in #43227 where reverse mapping fails cc @Cyrilvallez |
Member
|
@vasqu a quik fix that i found for now is to rename the tensor first and then transpose it. |
Contributor
Author
|
I'll wait for #43227 to be merged and then apply the final fix for the transposed experts. 🫡 |
Member
|
Closing as superseded by #43307! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the loading of qwen3vlmoe experts.
test script:
before:
The reason is that the official checkpoint of Qwen3VLMoe follows the shape
[num_experts, out_features, in_features], but in the latest code, these weights are transposed in the last two dimensions. This pr transposes them back during conversion.The model now loads successfully after the fix. 🫡