Skip to content

Add Cohere2 model#35224

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
alexrs-cohere:cohere-2025
Dec 13, 2024
Merged

Add Cohere2 model#35224
ArthurZucker merged 1 commit intohuggingface:mainfrom
alexrs-cohere:cohere-2025

Conversation

@alexrs-cohere
Copy link
Contributor

What does this PR do?

Add Cohere2 model to transformers.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @Cyrilvallez

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's improve this!

@ArthurZucker ArthurZucker merged commit 64478c7 into huggingface:main Dec 13, 2024
@guangy10
Copy link
Contributor

@alexrs-cohere Thanks for adding cohere2 with test for export to ExecuTorch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants