Skip to content

[tests] make test_sdpa_can_compile_dynamic device-agnostic#32519

Merged
amyeroberts merged 2 commits intohuggingface:mainfrom
faaany:enable_xpu
Aug 19, 2024
Merged

[tests] make test_sdpa_can_compile_dynamic device-agnostic#32519
amyeroberts merged 2 commits intohuggingface:mainfrom
faaany:enable_xpu

Conversation

@faaany
Copy link
Contributor

@faaany faaany commented Aug 8, 2024 •
edited
Loading

What does this PR do?

test_sdpa_can_compile_dynamic should not only work on GPU, it also works on XPU, below is an example:

PASSED tests/models/hubert/test_modeling_hubert.py::HubertModelTest::test_sdpa_can_compile_dynamic

@amyeroberts and @ydshieh

amyeroberts
amyeroberts approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling!

Similar to the other PR - we'll want to move this out of drafts and then run the slow tests before merge. Otherwise LGTM :)

@faaany faaany marked this pull request as ready for review August 9, 2024 02:28
@faaany
Copy link
Contributor Author

faaany commented Aug 9, 2024

Hi @amyeroberts , thanks for the review, undrafted!

@faaany
Copy link
Contributor Author

faaany commented Aug 13, 2024

can we merge this PR as well? Thx a lot!

@amyeroberts
Copy link
Contributor

amyeroberts commented Aug 14, 2024

Hi @faaany, apologies for the delay. I can see that adding the [run_all] tag didn't run the sdpa tests -- @ydshieh how can we trigger these?

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 14, 2024

Hi @amyeroberts This test is only for A10 or A100.

            if not torch.version.cuda or major < 8:
                self.skipTest(reason="This test requires an NVIDIA GPU with compute capability >= 8.0")

And so far, .github/workflows/self-pr-slow-ci.yml is only written to run on a T4.

The quick but manual way is to launch a A10 SSH runner

https://github.com/huggingface/transformers/actions/workflows/ssh-runner.yml

and run the tests manually.

@faaany
Copy link
Contributor Author

faaany commented Aug 19, 2024

Hi @amyeroberts , can we also proceed with merging of this PR?

@amyeroberts
Copy link
Contributor

amyeroberts commented Aug 19, 2024

Hi @faaany, yes, apologies for the delay. As this isn't changing any core logic it shouldn't really affect the slow tests so I think we can merge anyway

@amyeroberts amyeroberts merged commit e55b33c into huggingface:main Aug 19, 2024
@faaany faaany deleted the enable_xpu branch February 7, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amyeroberts amyeroberts amyeroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-slow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faaany @amyeroberts @ydshieh