Fix 29807 sinusoidal positional encodings in Flaubert, Informer and XLM#29904
Merged
ArthurZucker merged 8 commits intohuggingface:mainfrom Apr 2, 2024
Merged
Conversation
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
I think we could put everythin in the _init_weight? (trick is to use parent class)
Contributor
Author
|
I moved XLM and Flaubert to |
ArthurZucker
reviewed
Apr 1, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM just one nit to re-use the test and good to go!
| config_and_inputs = self.model_tester.prepare_config_and_inputs() | ||
| self.model_tester.create_and_check_flaubert_model(*config_and_inputs) | ||
|
|
||
| def test_flaubert_model_with_sinusoidal_encodings(self): |
Collaborator
There was a problem hiding this comment.
let's use copied from for the test as well!
Contributor
Author
There was a problem hiding this comment.
does this solve it?
| config_and_inputs = self.model_tester.prepare_config_and_inputs() | ||
| self.model_tester.create_and_check_xlm_model(*config_and_inputs) | ||
|
|
||
| def test_xlm_model_with_sinusoidal_encodings(self): |
Collaborator
There was a problem hiding this comment.
Yes, but we need "with Distlbert->XLM"
ArthurZucker
reviewed
Apr 1, 2024
| config_and_inputs = self.model_tester.prepare_config_and_inputs() | ||
| self.model_tester.create_and_check_xlm_model(*config_and_inputs) | ||
|
|
||
| def test_xlm_model_with_sinusoidal_encodings(self): |
Collaborator
There was a problem hiding this comment.
Yes, but we need "with Distlbert->XLM"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29807, sinusoidal positional encodings overwritten by post_init(), for Flauber, Informer and XLM models
Before submitting
to it if that's the case.
Sinusoidal positional encodings overwritten by post_init() #29807
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker, @younesbelkada, @amyeroberts