Fix docker image build for Latest PyTorch + TensorFlow [dev]#29764
Merged
Fix docker image build for Latest PyTorch + TensorFlow [dev]#29764
Latest PyTorch + TensorFlow [dev]#29764Conversation
ydshieh
commented
Mar 20, 2024
| # to be used as arguments for docker build (so far). | ||
|
|
||
| ARG PYTORCH='2.2.0' | ||
| ARG PYTORCH='2.2.1' |
Collaborator
Author
There was a problem hiding this comment.
let's use the latest one
ydshieh
commented
Mar 20, 2024
| ARG PYTORCH='2.2.0' | ||
| ARG PYTORCH='2.2.1' | ||
| # (not always a valid torch version) | ||
| ARG INTEL_TORCH_EXT='2.2.0' |
Collaborator
Author
There was a problem hiding this comment.
no 2.2.1 available for INTEL_TORCH_EXT yet. But I guess it's fine
ydshieh
commented
Mar 20, 2024
| # Currently, let's just use their latest releases (when `torch` is installed with a release version) | ||
| # TODO: We might need to specify proper versions that work with a specific torch version (especially for past CI). | ||
| RUN [ "$PYTORCH" != "pre" ] && python3 -m pip install --no-cache-dir -U $VERSION torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/$CUDA || python3 -m pip install --no-cache-dir -U --pre torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/nightly/$CUDA | ||
| RUN python3 -m pip install --no-cache-dir -U tensorflow==2.13 protobuf==3.20.3 tensorflow_text tensorflow_probability && python3 -m pip install --no-cache-dir -e ./transformers[dev,onnxruntime] && [ ${#PYTORCH} -gt 0 -a "$PYTORCH" != "pre" ] && VERSION='torch=='$PYTORCH'.*' || VERSION='torch'; echo "export VERSION='$VERSION'" >> ~/.profile && echo torch=$VERSION && [ "$PYTORCH" != "pre" ] && python3 -m pip install --no-cache-dir -U $VERSION torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/$CUDA || python3 -m pip install --no-cache-dir -U --pre torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/nightly/$CUDA |
Collaborator
Author
There was a problem hiding this comment.
put everything in a single RUN ... to reduce the layers and size.
Contributor
There was a problem hiding this comment.
This is such a hack 😅
I think we still want some of the comments to provide context
Collaborator
Author
There was a problem hiding this comment.
Added back (part of) the previous comments
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
Author
|
Hm, the last run on |
amyeroberts
approved these changes
Mar 21, 2024
| # Currently, let's just use their latest releases (when `torch` is installed with a release version) | ||
| # TODO: We might need to specify proper versions that work with a specific torch version (especially for past CI). | ||
| RUN [ "$PYTORCH" != "pre" ] && python3 -m pip install --no-cache-dir -U $VERSION torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/$CUDA || python3 -m pip install --no-cache-dir -U --pre torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/nightly/$CUDA | ||
| RUN python3 -m pip install --no-cache-dir -U tensorflow==2.13 protobuf==3.20.3 tensorflow_text tensorflow_probability && python3 -m pip install --no-cache-dir -e ./transformers[dev,onnxruntime] && [ ${#PYTORCH} -gt 0 -a "$PYTORCH" != "pre" ] && VERSION='torch=='$PYTORCH'.*' || VERSION='torch'; echo "export VERSION='$VERSION'" >> ~/.profile && echo torch=$VERSION && [ "$PYTORCH" != "pre" ] && python3 -m pip install --no-cache-dir -U $VERSION torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/$CUDA || python3 -m pip install --no-cache-dir -U --pre torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/nightly/$CUDA |
Contributor
There was a problem hiding this comment.
This is such a hack 😅
I think we still want some of the comments to provide context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's unknown why the image/layers could not be exported and pushed. The best guess is that it is way too large for which I don't know the limitation.
This PR combines several steps in one single
RUN ...command in the dockerfile so the size is smaller.Successful build: https://github.com/huggingface/transformers/actions/runs/8365229494/job/22902558338