Fix type hint for train_dataset param of Trainer.__init__() to allow IterableDataset. Issue 29678#29738
Merged
amyeroberts merged 3 commits intohuggingface:mainfrom Mar 22, 2024
Merged
Conversation
…terableDataset option.
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Mar 20, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding!
The failing test is unrelated to this PR - there was a fix pushed to main, could you try rebasing to include this update?
muellerzr
approved these changes
Mar 20, 2024
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Thanks! Agreed, we can merge once the ci is fully green (unrelated to you though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents introducing confusion for developers using PyRight and other type checking
systems when they try to use Trainer.train() as documented with an IterableDataset
for training.
No new dependencies.
Fixes #29678
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
@muellerzr , @pacman100