Skip to content

[docs] Spanish translation of attention.md#29681

Merged
stevhliu merged 6 commits intohuggingface:mainfrom
aaronjimv:translate_attention
Mar 15, 2024
Merged

[docs] Spanish translation of attention.md#29681
stevhliu merged 6 commits intohuggingface:mainfrom
aaronjimv:translate_attention

Conversation

@aaronjimv
Copy link
Contributor

What does this PR do?

Add the Spanish version of attention.md to transformers/docs/source/es

#28936

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

@aaronjimv
Copy link
Contributor Author

cc: @tadeodonegana. @gisturiz

Hello guys, I would appreciate if you can review the translation. Thank you.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it LGTM from my end! We can merge once the content has been reviewed 🤗


# Mecanismos de atención

La mayoría de los modelos de transformadores utilizan atención completa, en el sentido de que la matriz de atención es cuadrada. Esto puede ser un gran cuello de botella computacional cuando tienes textos largos. `Longformer` y `reformer` son modelos que intentan ser más eficientes y utilizan una versión dispersa de la matriz de atención para acelerar el entrenamiento.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When writing about transformers (specifically in the phrase "modelos de transformadores"), I believe that using 'transformadores' may not be the most accurate translation. In my opinion, it is preferable to consistently refer to them as "transformers," regardless of the language being used.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronjimv @stevhliu I just added this comment. I'm not sure if it's correct, but I wanted to express my thoughts on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @tadeodonegana thanks, I thinks its a good point. I going to use to "transformers"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when referring to the library, it is good to refer to it as just Transformers (no translation), but when referring to the models in a more generic way then it is ok to translate it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! Happy to help reviewing future translations! Great work @aaronjimv!

Copy link
Contributor

@gisturiz gisturiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 00c1d87 into huggingface:main Mar 15, 2024
@aaronjimv aaronjimv deleted the translate_attention branch March 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants