Add mlx support to BatchEncoding.convert_to_tensors#29406
Merged
ArthurZucker merged 4 commits intohuggingface:mainfrom Mar 4, 2024
tidely:main
Merged
Add mlx support to BatchEncoding.convert_to_tensors#29406ArthurZucker merged 4 commits intohuggingface:mainfrom tidely:main
ArthurZucker merged 4 commits intohuggingface:mainfrom
tidely:main
Conversation
Contributor
Author
|
Should be ready for review @ArthurZucker |
ArthurZucker
approved these changes
Mar 4, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM, clean addition thanks
Collaborator
|
Failing test is unrelated |
This was referenced Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the mlx array framework by Apple to BatchEncoding.convert_to_tensors
Fixes #29405