Fix llama + gemma accelete tests#29380
Merged
SunMarc merged 1 commit intohuggingface:mainfrom Mar 1, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 1, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Yessss! 🧼 Thanks you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the accelerate test for llama and gemma (
test_cpu_offload).The problem was that the
causal_maskbuffer was big compared to the small testing model. This resulted in edge cases where the model wasn't split since themodel_sizewas too big to start with andauto_infer_device_maponly allocates the parameters and not the buffers (supposed to be small).Related PR to fix these tests.
Tests passing: