Fix OneFormer post_process_instance_segmentation for panoptic tasks#29304
Merged
amyeroberts merged 2 commits intohuggingface:mainfrom Mar 4, 2024
Merged
Conversation
amyeroberts
reviewed
Feb 27, 2024
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing!
Could you add a test for post_process_instance_segmentation as well?
Contributor
Author
@amyeroberts added in a3f370b! Mind taking another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
post_process_instance_segmentationmethod of OneFormer.When specifying both
task_type="panoptic"andtarget_sizeinpost_process_instance_segmentation, theivariable would be overloaded by an enumeration. This would cause line 1265 (specifyingtarget_size) to blow up and throwIndexError: list index out of range. This PR fixes the variable overloading in the two places it could occur.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten @NielsRogge