Skip to content

Byebye torch 1.10 #28207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ydshieh merged 2 commits into from
Jan 11, 2024
Merged

Byebye torch 1.10 #28207

ydshieh merged 2 commits into from
Jan 11, 2024

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 22, 2023 •
edited
Loading

What does this PR do?

Byebye torch 1.10 ☃️

@ydshieh ydshieh force-pushed the byebye_torch_1.10 branch 2 times, most recently from 73fe085 to a974f21 Compare December 22, 2023 16:24
@ydshieh ydshieh marked this pull request as ready for review December 22, 2023 18:21
@ydshieh ydshieh force-pushed the byebye_torch_1.10 branch from a974f21 to 8669984 Compare January 8, 2024 10:56
@ydshieh ydshieh requested a review from ArthurZucker January 8, 2024 13:02
ArthurZucker
ArthurZucker approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🧹

tests/models/unispeech_sat/test_modeling_unispeech_sat.py
Copy link
Collaborator

@ArthurZucker ArthurZucker Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tolerances where not updated 👿

Copy link
Collaborator Author

@ydshieh ydshieh Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which tolerances you mean? I am not able to see the line

Copy link
Collaborator

@ArthurZucker ArthurZucker Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the TODO said update the tolerance after the CI moves to torch 1.10

Copy link
Collaborator Author

@ydshieh ydshieh Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes. Sorry. However I don't have the full context about this ... and we need @anton-l for the change if necessary

@ArthurZucker ArthurZucker mentioned this pull request Jan 11, 2024
Merged
@ydshieh
Copy link
Collaborator Author

ydshieh commented Jan 11, 2024

OK, going to merge. Feel free to drop a more detailed comment on tolerances if it's something needs to be fixed.

@ydshieh ydshieh merged commit 59cd9de into main Jan 11, 2024
@ydshieh ydshieh deleted the byebye_torch_1.10 branch January 11, 2024 15:18
@echarlaix echarlaix mentioned this pull request Jan 11, 2024
Merged
@tskir tskir mentioned this pull request Jan 22, 2024
Merged
@matthewdouglas matthewdouglas mentioned this pull request Feb 28, 2024
Closed
@amyeroberts amyeroberts mentioned this pull request Apr 26, 2024
Merged
7 tasks
@ji-huazhong ji-huazhong mentioned this pull request Jul 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ydshieh @LysandreJik @ArthurZucker