Skip to content

Fix beam score calculation issue for JAX version#27816

Merged
ArthurZucker merged 2 commits intohuggingface:mainfrom
VsonicV:beam_score_fix_jax_alone
Dec 7, 2023
Merged

Fix beam score calculation issue for JAX version#27816
ArthurZucker merged 2 commits intohuggingface:mainfrom
VsonicV:beam_score_fix_jax_alone

Conversation

@VsonicV
Copy link
Contributor

@VsonicV VsonicV commented Dec 3, 2023

What does this PR do?

This PR fixes the same beam score calculation issue following #27351 , for JAX version.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@gante

Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR 🙌

@gante gante requested a review from ArthurZucker December 5, 2023 11:39
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for propagating the fix

@ArthurZucker ArthurZucker merged commit 7fc8072 into huggingface:main Dec 7, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@VsonicV VsonicV deleted the beam_score_fix_jax_alone branch December 7, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants