Improve forward signature test#27729
Merged
ArthurZucker merged 4 commits intoDec 4, 2023
Merged
Conversation
5 tasks
ArthurZucker
approved these changes
Nov 28, 2023
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for being thorough with this refactor 🤗
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a follow-up of #27681, I'd like to make sure that every new backbone that is added to the library follows the same API. Hence, this PR extends the
test_forward_signaturetest to make sure this is tested.Rather than only checking the first keyword argument, it checks all of them.