Skip to content

Fix Past CI#27696

Merged
LysandreJik merged 1 commit intomainfrom
fix_past_ci
Nov 27, 2023
Merged

Fix Past CI#27696
LysandreJik merged 1 commit intomainfrom
fix_past_ci

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 24, 2023

What does this PR do?

Since mid-November, we have hundreds of following failures in each past CI

(line 1108) NotImplementedError: Loading a dataset cached in a LocalFileSystem is not supported.

It is caused by fsspec==2023.10.0 with an old datasets.

This PR just updates datasets (at CI runtime) to avoid, and fix thousand failures in total in past CI 🚀 🤣

@ydshieh ydshieh requested a review from LysandreJik November 24, 2023 17:10
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only updating datasets so let’s call it update dataset 🫣

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydshieh!

@LysandreJik LysandreJik merged commit e11e26d into main Nov 27, 2023
@LysandreJik LysandreJik deleted the fix_past_ci branch November 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants