Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
617b265 to
67ab444
Compare
ydshieh
commented
Nov 21, 2023
Collaborator
Author
ydshieh
left a comment
There was a problem hiding this comment.
Some comments to ease the review
LysandreJik
approved these changes
Nov 24, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Thanks Yih-Dar!
Additionnally I'd log a warning on load of this model that it was deprecated due to security issues, urging users to read this document (and linking to it).
I'd log it as logger.error in the tokenizer's __init__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate
TransfoXLas discussed.