Skip to content

docs: replace torch.distributed.run by torchrun#27528

Merged
amyeroberts merged 2 commits intohuggingface:mainfrom
panpan0000:main
Nov 27, 2023
Merged

docs: replace torch.distributed.run by torchrun#27528
amyeroberts merged 2 commits intohuggingface:mainfrom
panpan0000:main

Conversation

@panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented Nov 16, 2023 •
edited
Loading

What does this PR do?

The old way will be deprecated , move to new torchrun.
FutureWarning: The module torch.distributed.launch is deprecated and will be removed in future. Use torchrun.

This PR only addresses the doc part, not touching the unit-test to limit the impact.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@panpan0000
Copy link
Contributor Author

panpan0000 commented Nov 16, 2023

I just found an old PR which did the similar work https://github.com/huggingface/transformers/pull/21780/files but out of sync.
but my PR just focus on DOC

amyeroberts
amyeroberts approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Just a few comments on removing the changes for the research examples.

For any future readers who stumble on this PR: the previously closed PR requested comments in the docs for older pytorch versions. We now officially support pytorch >= 1.10. The entrypoint torchrun is present from 1.10 onwards.

@panpan0000
docs: replace torch.distributed.run by torchrun
ade77cc 
 `transformers` now officially support pytorch >= 1.10.
 The entrypoint `torchrun`` is present from 1.10 onwards.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@panpan0000
Copy link
Contributor Author

panpan0000 commented Nov 22, 2023

Thanks for adding this!

Just a few comments on removing the changes for the research examples.

For any future readers who stumble on this PR: the previously closed PR requested comments in the docs for older pytorch versions. We now officially support pytorch >= 1.10. The entrypoint torchrun is present from 1.10 onwards.

comments already addressed, now PR can be merged now.

ArthurZucker
ArthurZucker approved these changes Nov 22, 2023
View reviewed changes
@panpan0000 @ArthurZucker
Update src/transformers/trainer.py
986e1be 
with @ArthurZucker's suggestion

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
@amyeroberts amyeroberts merged commit ce31508 into huggingface:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

+1 more reviewer

@amyeroberts amyeroberts amyeroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panpan0000 @amyeroberts @ArthurZucker