Skip to content

Update tiny model summary file#27388

Merged
ydshieh merged 2 commits intomainfrom
update_tiny_models
Nov 23, 2023
Merged

Update tiny model summary file#27388
ydshieh merged 2 commits intomainfrom
update_tiny_models

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 9, 2023 •
edited
Loading

What does this PR do?

Update tiny model summary file (to enable pipeline testing for recently added models).

The following is a more detailed step on how to do this update (as a reference for the )

Steps

  1. Go to https://github.com/huggingface/transformers/actions/workflows/check_tiny_models.yml -> Click the latest successful run -> Download the artifact tiny_model_creation_reports -> Open the file updated_tiny_model_summary.json in the artifact and copy the content

  2. Paste the content copied in step 1. to tests/utils/tiny_model_summary.json

    • 2.1. Check the diff: if some architectures only get tokenizer/processor being created? if some recently added architectures in transformers not showing, etc. If so, we will need to check if we could do something.
    • 2.2. Once the changes look good, commit it.

  3. Update the mapping

  • 3.1 python utils\add_pipeline_model_mapping_to_test.py --all --overwrite
  • 3.2 ruff format examples tests src utils setup.py conftest.py
  • 3.3 ruff check examples tests src utils setup.py conftest.py --fix
  • 3.4 Commit the changes

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 9, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Nov 21, 2023 •
edited
Loading

Ignore this comment 🙏

(py38) λ ruff check examples tests src utils setup.py conftest.py --fix
tests\models\clvp\test_modeling_clvp.py:284:64: F821 Undefined name `PipelineTesterMixin`
tests\models\dpt\test_modeling_dpt_auto_backbone.py:143:35: F821 Undefined name `DPTModel`
tests\models\dpt\test_modeling_dpt_auto_backbone.py:144:35: F821 Undefined name `DPTForSemanticSegmentation`
tests\models\esm\test_modeling_esmfold.py:176:35: F821 Undefined name `EsmModel`
tests\models\esm\test_modeling_esmfold.py:177:26: F821 Undefined name `EsmForMaskedLM`
tests\models\esm\test_modeling_esmfold.py:178:36: F821 Undefined name `EsmForSequenceClassification`
tests\models\esm\test_modeling_esmfold.py:179:37: F821 Undefined name `EsmForTokenClassification`
tests\models\esm\test_modeling_esmfold.py:180:26: F821 Undefined name `EsmForSequenceClassification`
tests\models\fuyu\test_modeling_fuyu.py:265:39: F821 Undefined name `PipelineTesterMixin`
tests\models\kosmos2\test_modeling_kosmos2.py:247:42: F821 Undefined name `PipelineTesterMixin`
tests\models\seamless_m4t\test_modeling_seamless_m4t.py:620:46: F821 Undefined name `PipelineTesterMixin`
Found 11 errors.

check dpt, permission and esmfold
check TFLayoutLMv3ForQuestionAnswering

@ydshieh ydshieh marked this pull request as ready for review November 23, 2023 13:57
ydshieh
ydshieh commented Nov 23, 2023
View reviewed changes
src/transformers/models/auto/image_processing_auto.py
("idefics", "IdeficsImageProcessor"),
("imagegpt", "ImageGPTImageProcessor"),
("instructblip", "BlipImageProcessor"),
("kosmos-2", "CLIPImageProcessor"),
Copy link
Collaborator Author

@ydshieh ydshieh Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed in Kosmos-2 PR.

We need this otherwise pipeline don't know what to do.

@ydshieh ydshieh requested a review from ArthurZucker November 23, 2023 14:21
@ydshieh ydshieh mentioned this pull request Nov 23, 2023
Merged
ArthurZucker
ArthurZucker approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me! 🪂

tests/models/seamless_m4t/test_modeling_seamless_m4t.py
else ()
)
all_generative_model_classes = (SeamlessM4TForTextToText,) if is_torch_available() else ()
pipeline_model_mapping = (
Copy link
Collaborator

@ArthurZucker ArthurZucker Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@ydshieh ydshieh merged commit b8db265 into main Nov 23, 2023
@ydshieh ydshieh deleted the update_tiny_models branch November 23, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ydshieh @HuggingFaceDocBuilderDev @ArthurZucker