Skip to content

[core] Fix gradient checkpointing use_reentrant issues#26917

Closed
younesbelkada wants to merge 1 commit intohuggingface:mainfrom
younesbelkada:fix-gc-use-reentrant
Closed

[core] Fix gradient checkpointing use_reentrant issues#26917
younesbelkada wants to merge 1 commit intohuggingface:mainfrom
younesbelkada:fix-gc-use-reentrant

Conversation

@younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Oct 18, 2023

What does this PR do?

Partially fixes: huggingface/trl#835 more details coming soon

@younesbelkada younesbelkada changed the title [core] Fix gradient checkpointing use_reentrant [core] Fix gradient checkpointing use_reentrant issues Oct 18, 2023
@younesbelkada younesbelkada marked this pull request as draft October 18, 2023 23:25
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RewardTrainer] Enable gradient checkpointing for all multi-GPU training modes

1 participant