Add many missing spaces in adjacent strings#26751
Merged
LysandreJik merged 1 commit intohuggingface:mainfrom Oct 12, 2023
Merged
Add many missing spaces in adjacent strings#26751LysandreJik merged 1 commit intohuggingface:mainfrom
LysandreJik merged 1 commit intohuggingface:mainfrom
Conversation
LysandreJik
approved these changes
Oct 12, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Hey @tomaarsen, thanks, this looks good to me! There were a lot!
Member
|
CI error is superfluous, merging! |
Member
Author
|
Awesome! Thanks for getting to this so quickly, these kinds of PRs can become a merge conflict mess if they're left for too long. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
What does this PR do?
This PR resolves numerous occurrences of the following:
Which results in errors like:
How did I go about it?
I created a simple regex:
(["'][^"'\n]*[^ n])(["']\n *f?r?["'][^ ]), which matches full strings that don't end with spaces orn(due to\n), followed by a newline, some spaces, and then another string that also doesn't start with a space. I manually went over all cases where this pattern matched through the codebase, and replaced the pattern with$1 $2if it was indeed a real mistake.Before submitting
Who can review?
@ArthurZucker