fix the model card issue as use_cuda_amp is no more available#26731
Merged
LysandreJik merged 1 commit intomainfrom Oct 11, 2023
Merged
fix the model card issue as use_cuda_amp is no more available#26731LysandreJik merged 1 commit intomainfrom
use_cuda_amp is no more available#26731LysandreJik merged 1 commit intomainfrom
Conversation
muellerzr
approved these changes
Oct 11, 2023
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Thanks for the quick fix Sourab!
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
reviewed
Oct 11, 2023
| if trainer.use_apex: | ||
| hyperparameters["mixed_precision_training"] = f"Apex, opt level {trainer.args.fp16_opt_level}" | ||
| else: | ||
| hyperparameters["mixed_precision_training"] = "Native AMP" |
Collaborator
There was a problem hiding this comment.
I don't know well this part. Could you share why use_cuda_amp is no longer available from trainer? Otherwise LGTM. Thank you!
Contributor
There was a problem hiding this comment.
SharedDDP was deprecated (and now removed) in favor of using Accelerate natively: #25702
LysandreJik
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
extract_hyperparameters_from_trainertries to accessuse_cuda_ampattribute which is no more available.