fix typos in idefics.md#26648
Merged
LysandreJik merged 2 commits intohuggingface:mainfrom Oct 9, 2023
Merged
Conversation
Two typos found in reviewing this documentation. 1) max_new_tokens=4, is not sufficient to generate "Vegetables" as indicated - you will get only "Veget". (incidentally - some mention of how to select this value might be useful as it seems to change in each example) 2) inputs = processor(prompts, return_tensors="pt").to(device) as inputs need to be on the same device (as they are in all other examples on the page)
LysandreJik
reviewed
Oct 9, 2023
docs/source/en/tasks/idefics.md
Outdated
| ... ] | ||
|
|
||
| >>> inputs = processor(prompts, return_tensors="pt") | ||
| >>> inputs = processor(prompts, return_tensors="pt").to(device) |
Member
There was a problem hiding this comment.
"cuda" is used everywhere else in the doc, shouldn't it be the same here?
Contributor
Author
There was a problem hiding this comment.
You are right - in all examples above we use "cuda" and should here as well. It is only in the example below that we switch to the device variable. 👍
Change device to cuda explicitly to match other examples
LysandreJik
approved these changes
Oct 9, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Cool, thanks @dribnet!
Merging :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two typos found in reviewing this documentation.
max_new_tokens=6 as 4 is not sufficient to generate "Vegetables" as indicated - you will get only "Veget". (incidentally - some mention of how to select this value might be useful as it seems to change in each example)
inputs = processor(prompts, return_tensors="pt")).to(device) as inputs need to be on the same device (as they are in all other examples on the page)
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.