Conversation
There was a problem hiding this comment.
for Hubert and Wav2Vec2, fx tracing starts to fail with torch 2.1
There was a problem hiding this comment.
despite the changes in the modeling files, this part still fails
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks, let's try to use unitest skip and put the torch fx proxy in the model forward
There was a problem hiding this comment.
Instead of commenting we can add something like
self.skipTest("Skipping until we fix it ")There was a problem hiding this comment.
let's do the check a lot earlier, we can check this in the model's forward only once!
There was a problem hiding this comment.
I am not sure about this place. This block contain
attn_weights = attn_weights.view(bsz, self.num_heads, tgt_len, src_len) + attention_mask
attn_weights = attn_weights.view(bsz * self.num_heads, tgt_len, src_len)
and it should be run no matter if we are in fx proxy or not
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, let's ensure we check for eventual performance issues and fix the TODOs quickly.
Thanks for fixing these tests so quickly!
|
The documentation is not available anymore as the PR was closed or merged. |
|
@michaelbenayoun Could you help us on the torch fx tests for wav2vec2/hubert with torch 2.1. But in short, it can't do as the corresponding proxy object has no |
What does this PR do?
Fix failing tests on
maindue to torch 2.1