[LlamaTokenizerFast] Adds edge cases for the template processor #26606
Merged
LysandreJik merged 6 commits intohuggingface:mainfrom Oct 6, 2023
Merged
[LlamaTokenizerFast] Adds edge cases for the template processor #26606LysandreJik merged 6 commits intohuggingface:mainfrom
LlamaTokenizerFast] Adds edge cases for the template processor #26606LysandreJik merged 6 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Oct 5, 2023
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
LysandreJik
approved these changes
Oct 6, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, thanks @ArthurZucker!
The failing tests look flaky?
Collaborator
Author
|
Yep rebased on main to remove them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #26605 by making sure the LlamaTokenizerFast handles the cases when bos or eos is None and
add_bos_tokenis set toTrueby raising an error.