Skip to content

Fixed inconsistency in several fast tokenizers#26561

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
Towdo:fix_bert_tokenizer
Oct 6, 2023
Merged

Fixed inconsistency in several fast tokenizers#26561
ArthurZucker merged 1 commit intohuggingface:mainfrom
Towdo:fix_bert_tokenizer

Conversation

@Towdo
Copy link
Contributor

@Towdo Towdo commented Oct 3, 2023 •
edited
Loading

Fixed case where behavior of BertTokenizer and BertTokenizerFast is different.
An empty list will be evaluated to False but not to is None.

(I mistakenly closed my first merge request)

Fixes #26123

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

ArthurZucker
ArthurZucker reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these changes! Let's add a small test in the test_tokenization_common 😉

@Towdo Towdo requested a review from ArthurZucker October 5, 2023 12:46
@Towdo
Copy link
Contributor Author

Towdo commented Oct 5, 2023

Thanks a lot for these changes! Let's add a small test in the test_tokenization_common 😉

I changed the test_build_inputs_with_special_tokens to test this edge case :)

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Oct 5, 2023

Thanks 😉

ArthurZucker
ArthurZucker approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good thanks, I would just like 1 hard coded expected value, otherwise if both are broken we are not testing anything! Thanks for the fix

@Towdo
Copy link
Contributor Author

Towdo commented Oct 5, 2023 •
edited
Loading

Very good thanks, I would just like 1 hard coded expected value, otherwise if both are broken we are not testing anything! Thanks for the fix

Can you give me some guidance on how to do this?
Because the behaviour differs from tokenizer to tokenizer, I can't/shouldn't do it in test_tokenization_common, right?
So instead I hard code one test in each test_tokenization_(tokenizer)?

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Oct 6, 2023

Oups my bad on this one!
It's alright like this 😉 I'll merge

@ArthurZucker ArthurZucker merged commit af38c83 into huggingface:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency in BertFastTokenizer

2 participants

@Towdo @ArthurZucker