Warnings controlled by logger level#26527
Merged
LysandreJik merged 2 commits intomainfrom Oct 12, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Oct 2, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Could you explain a bit more what this involves + guidelines for futur PR's ?
|
|
||
| By default, `tqdm` progress bars will be displayed during model download. [`logging.disable_progress_bar`] and [`logging.enable_progress_bar`] can be used to suppress or unsuppress this behavior. | ||
|
|
||
| ## `logging` vs `warnings` |
Collaborator
There was a problem hiding this comment.
Can you add an example of what this means for us now?
(calling logger with deprecation warning for example?) for all devs !
Member
Author
There was a problem hiding this comment.
You don't call logger with deprecation warnings, you just use warnings.warn. But now, you can capture those and eliminate them from the logging system simply.
Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com>
5880e05 to
6a60643
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitely shows how to control
warningsusing thelogginglevel setters in `transformers.Fix #26381