[Doctest] Add configuration_encoder_decoder.py#26519
[Doctest] Add configuration_encoder_decoder.py#26519ydshieh merged 7 commits intohuggingface:mainfrom
configuration_encoder_decoder.py#26519Conversation
Added configuration_encoder_decoder.py to utils/documentation_tests.txt for doctest
This reverts commit bd65353.
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
|
@ydshieh please look into this. I'm to this. |
ydshieh
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Left a few comments to address :-)
|
|
||
| ```python | ||
| >>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel | ||
| >>> from transformers import EncoderDecoderModel, EncoderDecoderConfig, BertConfig |
There was a problem hiding this comment.
We should keep the previous order.
There was a problem hiding this comment.
did it, please check.
utils/documentation_tests.txt
Outdated
There was a problem hiding this comment.
This file is no longer used. Could you revert the change here. Then remove the entry src/transformers/models/encoder_decoder/configuration_encoder_decoder.py from the list utils/not_doctested.txt.
| Examples: | ||
|
|
||
| ```python | ||
| >>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel |
There was a problem hiding this comment.
this line should not be changed, keep it as BertConfig, EncoderDecoderConfig, EncoderDecoderModel
There was a problem hiding this comment.
Heya, i fixed it again, please review and give feedback. Thank you <3
if it is possible, may i contact you on discord. i want to ask some questions regarding opensource and contributing to huggingface etc.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
What does this PR do?
Fixes #19487
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.