[core] Fix keep in fp32 silent bug#26484
Closed
younesbelkada wants to merge 7 commits intohuggingface:mainfrom
Closed
[core] Fix keep in fp32 silent bug#26484younesbelkada wants to merge 7 commits intohuggingface:mainfrom
core] Fix keep in fp32 silent bug#26484younesbelkada wants to merge 7 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this PR we were performing a simple check
if module_name in keybut that lead to some modules silently converted in fp32.For example instructblip models got their
word_embeddinglayers converted in fp32 because_keep_in_fp32_modulesincludes"wo"which is contained in the stringword_embedding. The fix is to check ifmodule_name in key.split(".")cc @ydshieh
Related bnb and T5 test all pass
Need to investigate if instructblip tests pass