Update docs to explain disabling callbacks using report_to#26155
Merged
muellerzr merged 2 commits intohuggingface:mainfrom Oct 11, 2023
Merged
Update docs to explain disabling callbacks using report_to#26155muellerzr merged 2 commits intohuggingface:mainfrom
muellerzr merged 2 commits intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Sep 14, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks looks good to me
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
muellerzr
approved these changes
Sep 14, 2023
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Thanks! This is great!
As part of this, can we update https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#L2385-L2388 to basically be a repeat of https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#L522-L526? Otherwise LG2M as well :)
Contributor
Author
|
@muellerzr sure! Just pushed that change. |
muellerzr
approved these changes
Sep 14, 2023
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Phenomenal! Good to go on my side then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #26036. I added clarification to the Callback documentation page explaining how to "turn off" default callbacks using
TrainerArguments.report_to.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr @pacman100