Merged
Conversation
sgugger
approved these changes
Jul 17, 2023
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this! Just one comment on the docstring.
Please hold off merging until the release branch has been cut.
sgugger
reviewed
Jul 17, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR deprecates the
no_cudaarg because it is confusing for Mac users as their models get dispatched tompsdevice whenno_cuda=False. If they want to train the model on cpu, they need to setno_cuda=Truewhich is not intuitive. We rename ituse_cpuinstead.Related issue #24697