Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Jul 13, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this deprecation logic!
ydshieh
approved these changes
Jul 13, 2023
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
Thanks for taking care of the CI cost!
LysandreJik
approved these changes
Jul 13, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Yes, I think the combination of:
- Keeping the models in the main init
- Marking them as deprecated
- Not having them tested
is good.
Co-authored-by: Lysandre Debut <lysandre.debut@reseau.eseo.fr>
Collaborator
|
FMI: (M=my) I probably need to do something with daily CI to take this PR's change into account! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates the precedent of deprecating models in the library. By deprecating we indicate that we will stop maintaining such models, but there is no intention of actually removing those models and breaking support for them (they might one day move into a separate repo/on the Hub but we would still add the necessary imports to make sure backward compatibility stays). The main point is that we stop testing those models (to ease a bit the burden on our CI).
Deprecated models are moved in models/deprecated so direct import of objects from their modeling files will break (though that's easily fixed by adding the
.deprecatedin the path). They are removed from thetestsfolder and a mention is added in the doc page of the model.The heuristic to pick the deprecated models in this PR is: models older than a year that got less than a cumulated 1,000 downloads (over all checkpoints) in the last 30 days (counting deduplicated downloads).