Update PT/TF weight conversion after #24030#24547
Merged
Merged
Conversation
ydshieh
commented
Jun 28, 2023
ydshieh
commented
Jun 28, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Jun 28, 2023
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for working on this! Just a few comments on the variable names.
sgugger
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update PT/TF weight conversion due to the change in #24030.
(can do PT/Flax too in the same PR, but request a review first anyway)
Code snippet to show issues and verify this PR's effect
(Failing for
main + nightly torch. Pass forPR + nightly torchandmain/PR + stable torch)