Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Ah, this explains why the previous example had several issues 😅 @ydshieh We don't plan to add FLAX to the doctests, correct? |
Collaborator
Author
|
@gante Not a no from me. I think it's good to make sure the examples work (this is in the range of maintenance mode 😄 ). But I would like to have a yes from @sgugger and @LysandreJik before working on it. |
Collaborator
|
Not worth any work right now given the usage IMO. There is plenty to do with more priority :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#21009 added
src/transformers/generation/flax_utils.pytodocumentation_tests.txt, but CI image doesn't havejax/flaxinstalled. The whole doctest suite failed, and reported 0 failure.This PR removes this file from
documentation_tests.txt. The CI image used is the same as the scheduled CI, and it's intended not to havejax/flaxin this image.We can decide if to use a separate image though.