feature: update wandb callback to upload checkpoints#21035
Merged
sgugger merged 12 commits intohuggingface:mainfrom Jan 10, 2023
Merged
feature: update wandb callback to upload checkpoints#21035sgugger merged 12 commits intohuggingface:mainfrom
sgugger merged 12 commits intohuggingface:mainfrom
Conversation
added 5 commits
January 6, 2023 21:17
- removes duplicated run names from wandb workspace - models can be logged with corresponding run names
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Jan 7, 2023
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for your PR! I left a couple of comments.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Contributor
Author
|
Hey, @sgugger : Thanks for the quick review and suggestions. I've resolved all the issues. 🤗 |
Collaborator
|
@parambharat There is a weird issue with the tests. Could you try refreshing your permissions as shown here and then pushing an empty commit? |
Contributor
Author
|
Hey, @sgugger. I ran the fix that you suggested and all checks pass now. |
stevhliu
approved these changes
Jan 9, 2023
Member
stevhliu
left a comment
There was a problem hiding this comment.
Thanks for updating! I left two suggestions on formatting :)
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Contributor
Author
|
Thank you @stevhliu. I've committed your recommendations. |
Collaborator
|
Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR updates the
WandbCallbackwith the following changes:on_savemethod to upload model checkpoints as artifacts.WANDB_WATCHfromgradientstofalse. This enables quicker training when defaults are used. The user can easily change this behavior by setting the env variable.WANDB_LOG_MODELvariable frombooltostrallowing for different settings to upload artifacts.run_namefromoutput_dirto wandb auto generated name. this avoids duplication of run names in wandb workspaceBefore submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Examples