Preserve hub-related kwargs in AutoModel.from_pretrained #18545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
commented
Aug 9, 2022
| elif "model_type" in config_dict: | ||
| config_class = CONFIG_MAPPING[config_dict["model_type"]] | ||
| return config_class.from_dict(config_dict, **kwargs) | ||
| return config_class.from_dict(config_dict, **unused_kwargs) |
Collaborator
Author
There was a problem hiding this comment.
We replicate the logic inside from_pretrained here, but duplicating some of the kwargs.
LysandreJik
approved these changes
Aug 10, 2022
Member
LysandreJik
left a comment
There was a problem hiding this comment.
This looks good, quite elegant! Thanks for catching and patching the issue.
| elif "model_type" in config_dict: | ||
| config_class = CONFIG_MAPPING[config_dict["model_type"]] | ||
| return config_class.from_dict(config_dict, **kwargs) | ||
| return config_class.from_dict(config_dict, **unused_kwargs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As was reported in #18537, when using
AutoConfiginside theAutoModel.from_pretrainedmethod, some kwargs are deleted and not passed to thefrom_pretrainedmethod of the model. This PR makes sure they are preserved for those calls.Fixes #18537