Fix special tokens addition in decoder #1807 #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
==========================================
- Coverage 84.16% 84.08% -0.09%
==========================================
Files 94 94
Lines 14185 14047 -138
==========================================
- Hits 11939 11811 -128
+ Misses 2246 2236 -10
Continue to review full report at Codecov.
|
Member
|
Nice fix, a lot cleaner as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue detailed in #1807
Added special tokens should not be present when decoding with the
skip_special_tokensflag set toTrue.Using the
convert_tokens_to_idschecks whether those added tokens are present and removes them if necessary.